From aab5be7b71f93e077ddb2cb6cc08595722b812cc Mon Sep 17 00:00:00 2001 From: =?utf8?q?=C5=A0t=C4=9Bp=C3=A1n=20Bal=C3=A1=C5=BEik?= Date: Fri, 22 Jan 2021 19:22:20 +0100 Subject: [PATCH] selection: only report RTT if there is an answer Previously this would pollute the RTT cache with non-sensical measurements from unsuccessful TCP connects for example. --- daemon/worker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/worker.c b/daemon/worker.c index 8f7382a4e..8a6d08b75 100644 --- a/daemon/worker.c +++ b/daemon/worker.c @@ -1599,7 +1599,7 @@ static int qr_task_step(struct qr_task *task, } // Report network RTT back to server selection - if (task->send_time && task->recv_time) { + if (packet && task->send_time && task->recv_time) { struct kr_query *qry = array_tail(req->rplan.pending); qry->server_selection.update_rtt(qry, task->transport, task->recv_time - task->send_time); } -- 2.47.2