From aae31db26dacf1a41271beed89636985cbfd294f Mon Sep 17 00:00:00 2001 From: =?utf8?q?Henryk=20Pl=C3=B6tz?= Date: Thu, 9 Aug 2018 21:07:40 +0200 Subject: [PATCH] More DRY, less repeating --- fints/segments/__init__.py | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/fints/segments/__init__.py b/fints/segments/__init__.py index 8115db8..5d0ae96 100644 --- a/fints/segments/__init__.py +++ b/fints/segments/__init__.py @@ -133,22 +133,17 @@ class HISYN4(FinTS3Segment): security_reference_signature_key = DataElementField(type='num', max_length=16, required=False) security_reference_digital_signature = DataElementField(type='num', max_length=16, required=False) - -class HITANS1(FinTS3Segment): +class ParameterSegment(FinTS3Segment): max_number_tasks = DataElementField(type='num', max_length=3) min_number_signatures = DataElementField(type='num', length=1) security_class = DataElementField(type='num', length=1) - parameters_twostep_tan = DataElementGroupField(type=ParameterTwostepTAN1) -class HITANS3(FinTS3Segment): - max_number_tasks = DataElementField(type='num', max_length=3) - min_number_signatures = DataElementField(type='num', length=1) - security_class = DataElementField(type='num', length=1) - parameters_twostep_tan = DataElementGroupField(type=ParameterTwostepTAN3) +class HITANS1(ParameterSegment): + parameters = DataElementGroupField(type=ParameterTwostepTAN1) -class HIPINS1(FinTS3Segment): - max_number_tasks = DataElementField(type='num', max_length=3) - min_number_signatures = DataElementField(type='num', length=1) - security_class = DataElementField(type='num', length=1) - parameters_pintan = DataElementGroupField(type=ParameterPinTan) +class HITANS3(ParameterSegment): + parameters = DataElementGroupField(type=ParameterTwostepTAN3) + +class HIPINS1(ParameterSegment): + parameters = DataElementGroupField(type=ParameterPinTan) -- 2.39.5