From ab0137b44a4b0cf738381ef2109099dfd2f991a3 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Tue, 21 May 2024 09:08:48 +0200 Subject: [PATCH] shared/btrfs-util: simplify return conditions Coverity has trouble undertanding this function, so let's get rid of the redundant return branch to simplify the code. --- src/shared/btrfs-util.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/shared/btrfs-util.c b/src/shared/btrfs-util.c index d6b218d842f..a7881b8b7e7 100644 --- a/src/shared/btrfs-util.c +++ b/src/shared/btrfs-util.c @@ -1637,13 +1637,10 @@ int btrfs_qgroup_find_parents(int fd, uint64_t qgroupid, uint64_t **ret) { break; } - if (n_items <= 0) { - *ret = NULL; - return 0; - } + assert((n_items > 0) == !!items); + assert(n_items <= INT_MAX); *ret = TAKE_PTR(items); - return (int) n_items; } -- 2.47.3