From aba9c23a6e1cb134840c998df14888dca469a485 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 4 Aug 2017 12:02:41 -0700 Subject: [PATCH] ss: enclose IPv6 address in brackets Based on patch by Lehner Florian Adds support for RFC2732 IPv6 address format with brackets. Signed-off-by: Stephen Hemminger --- misc/ss.c | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 12763c9f4..f0d1c22f7 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -1059,12 +1059,25 @@ static void inet_addr_print(const inet_prefix *a, int port, unsigned int ifindex ap = format_host(AF_INET, 4, a->data); } } else { - ap = format_host(a->family, 16, a->data); - est_len = strlen(ap); - if (est_len <= addr_width) - est_len = addr_width; - else - est_len = addr_width + ((est_len-addr_width+3)/4)*4; + if (!memcmp(a->data, &in6addr_any, sizeof(in6addr_any))) { + buf[0] = '*'; + buf[1] = 0; + } else { + ap = format_host(a->family, 16, a->data); + + /* Numeric IPv6 addresses should be bracketed */ + if (strchr(ap, ':')) { + snprintf(buf, sizeof(buf), + "[%s]", ap); + ap = buf; + } + + est_len = strlen(ap); + if (est_len <= addr_width) + est_len = addr_width; + else + est_len = addr_width + ((est_len-addr_width+3)/4)*4; + } } if (ifindex) { -- 2.47.2