From ac212ecc65a540453ac64f420133e0208f8a6fb8 Mon Sep 17 00:00:00 2001 From: "William A. Rowe Jr" Date: Tue, 29 Oct 2002 21:12:34 +0000 Subject: [PATCH] Fix memory leak in mod_ssl from internal SSL library allocations within SSL_get_peer_certificate and X509_get_pubkey. Submitted by: Zvi Har'El Reviewed by: Madhusudan Mathihalli git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97344 13f79535-47bb-0310-9956-ffa450edef68 --- CHANGES | 5 +++++ modules/ssl/ssl_engine_init.c | 1 + 2 files changed, 6 insertions(+) diff --git a/CHANGES b/CHANGES index d208dce7952..db36e11645d 100644 --- a/CHANGES +++ b/CHANGES @@ -1,5 +1,10 @@ Changes with Apache 2.0.44 + *) Fix memory leak in mod_ssl from internal SSL library allocations + within SSL_get_peer_certificate and X509_get_pubkey. + [Zvi Har'El + Madhusudan Mathihalli ]. + *) mod_ssl uses free() inappropriately in several places, to free memory which has been previously allocated inside OpenSSL. Such memory should be freed with OPENSSL_free(), not with free(). diff --git a/modules/ssl/ssl_engine_init.c b/modules/ssl/ssl_engine_init.c index bf63baf4c1a..b387ccc9447 100644 --- a/modules/ssl/ssl_engine_init.c +++ b/modules/ssl/ssl_engine_init.c @@ -807,6 +807,7 @@ static int ssl_server_import_key(server_rec *s, ap_log_error(APLOG_MARK, APLOG_ERR, 0, s, "Copying DSA parameters from private key to certificate"); ssl_log_ssl_error(APLOG_MARK, APLOG_ERR, s); + EVP_PKEY_free(pubkey); } } -- 2.47.2