From b082880ca6a4888dc4412e8fb1747fe19f26f627 Mon Sep 17 00:00:00 2001 From: Thomas Markwalder Date: Tue, 9 Jul 2019 10:13:33 -0400 Subject: [PATCH] [#722,!1] Addressed review comments Added test to ensure DUID size constant(s) are RFC compliant --- src/lib/dhcp/tests/duid_unittest.cc | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/lib/dhcp/tests/duid_unittest.cc b/src/lib/dhcp/tests/duid_unittest.cc index 108bbe4d1e..d9bb7e1014 100644 --- a/src/lib/dhcp/tests/duid_unittest.cc +++ b/src/lib/dhcp/tests/duid_unittest.cc @@ -62,6 +62,10 @@ TEST(DuidTest, constructor) { // This test verifies if DUID size restrictions are implemented // properly. TEST(DuidTest, size) { + + // Ensure that our size constant is RFC-compliant. + ASSERT_EQ(128, MAX_DUID_LEN); + uint8_t data[MAX_DUID_LEN + 1]; vector data2; for (uint8_t i = 0; i < MAX_DUID_LEN + 1; ++i) { @@ -220,6 +224,9 @@ TEST(ClientIdTest, constructor) { // Check that client-id sizes are reasonable TEST(ClientIdTest, size) { + // Ensure that our size constant is RFC-compliant. + ASSERT_EQ(128, MAX_CLIENT_ID_LEN); + uint8_t data[MAX_CLIENT_ID_LEN + 1]; vector data2; for (uint8_t i = 0; i < MAX_CLIENT_ID_LEN + 1; ++i) { -- 2.47.2