From b17b91db8060b7ac65e20834d3b4c40d4985a9ca Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Tue, 14 May 2024 18:51:57 +0200 Subject: [PATCH] libsystemd-network: use normal style for error checking We generally use a flat list. The switch stmt was generating excessive indentation. --- src/libsystemd-network/icmp6-packet.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/src/libsystemd-network/icmp6-packet.c b/src/libsystemd-network/icmp6-packet.c index f447549dc86..02865a40c25 100644 --- a/src/libsystemd-network/icmp6-packet.c +++ b/src/libsystemd-network/icmp6-packet.c @@ -113,20 +113,14 @@ int icmp6_packet_receive(int fd, ICMP6Packet **ret) { return -ENOMEM; r = icmp6_receive(fd, p->raw_packet, p->raw_size, &p->sender_address, &p->timestamp); + if (r == -EADDRNOTAVAIL) + return log_debug_errno(r, "ICMPv6: Received a packet from neither link-local nor null address."); + if (r == -EMULTIHOP) + return log_debug_errno(r, "ICMPv6: Received a packet with an invalid hop limit."); + if (r == -EPFNOSUPPORT) + return log_debug_errno(r, "ICMPv6: Received a packet with an invalid source address."); if (r < 0) - switch (r) { - case -EADDRNOTAVAIL: - return log_debug_errno(r, "ICMPv6: Received a packet from neither link-local nor null address."); - - case -EMULTIHOP: - return log_debug_errno(r, "ICMPv6: Received a packet with an invalid hop limit."); - - case -EPFNOSUPPORT: - return log_debug_errno(r, "ICMPv6: Received a packet with an invalid source address."); - - default: - return log_debug_errno(r, "ICMPv6: Unexpected error while receiving a packet: %m"); - } + return log_debug_errno(r, "ICMPv6: Unexpected error while receiving a packet: %m"); r = icmp6_packet_verify(p); if (r < 0) -- 2.47.3