From b1fab0c21c77cf72acfc7e961b25dc34465e98ed Mon Sep 17 00:00:00 2001 From: Chris Wong Date: Wed, 21 Apr 2010 11:47:15 +0200 Subject: [PATCH] esx: Don't treat an empty root snapshot list as error An empty root snapshot list was considered as error condition. Creating a new snapshot would fail if the domain didn't have snapshots yet, because the snapshot-create function tries to lookup the list of existing snapshots in order to verify that the snapshot name is unique. This fails if the domain doesn't have snapshots yet. Removing the NULL check from esxVI_LookupRootSnapshotTreeList fixes this. --- src/esx/esx_vi.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c index e405c8038f..966ef85eb1 100644 --- a/src/esx/esx_vi.c +++ b/src/esx/esx_vi.c @@ -2503,12 +2503,6 @@ esxVI_LookupRootSnapshotTreeList } } - if (*rootSnapshotTreeList == NULL) { - ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "%s", - _("Could not lookup root snapshot list")); - goto failure; - } - cleanup: esxVI_String_Free(&propertyNameList); esxVI_ObjectContent_Free(&virtualMachine); -- 2.47.2