From b29a0a37f46bbfd2a36eff73eb66249d7baaf71a Mon Sep 17 00:00:00 2001 From: Thorsten Blum Date: Tue, 16 Dec 2025 15:52:37 +0100 Subject: [PATCH] dcache: Replace simple_strtoul with kstrtoul in set_dhash_entries Replace simple_strtoul() with the recommended kstrtoul() for parsing the 'dhash_entries=' boot parameter. Check the return value of kstrtoul() and reject invalid values. This adds error handling while preserving behavior for existing values, and removes use of the deprecated simple_strtoul() helper. Signed-off-by: Thorsten Blum Link: https://patch.msgid.link/20251216145236.44520-2-thorsten.blum@linux.dev Reviewed-by: Jan Kara Signed-off-by: Christian Brauner --- fs/dcache.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/dcache.c b/fs/dcache.c index dc2fff4811d15..ec275f4fd81cd 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -3227,10 +3227,7 @@ EXPORT_SYMBOL(d_parent_ino); static __initdata unsigned long dhash_entries; static int __init set_dhash_entries(char *str) { - if (!str) - return 0; - dhash_entries = simple_strtoul(str, &str, 0); - return 1; + return kstrtoul(str, 0, &dhash_entries) == 0; } __setup("dhash_entries=", set_dhash_entries); -- 2.47.3