From b34d4b131425e628b19058b8d2917b2ba9085727 Mon Sep 17 00:00:00 2001 From: Philippe Antoine Date: Sun, 23 Jun 2024 22:57:11 +0200 Subject: [PATCH] detect/nfs: do not free a null pointer https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=69840 --- src/detect-nfs-procedure.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/detect-nfs-procedure.c b/src/detect-nfs-procedure.c index 3afa327bec..45d8311103 100644 --- a/src/detect-nfs-procedure.c +++ b/src/detect-nfs-procedure.c @@ -162,7 +162,7 @@ static int DetectNfsProcedureSetup (DetectEngineCtx *de_ctx, Signature *s, dd = DetectNfsProcedureParse(rawstr); if (dd == NULL) { SCLogError("Parsing \'%s\' failed", rawstr); - goto error; + return -1; } /* okay so far so good, lets get this into a SigMatch @@ -171,13 +171,10 @@ static int DetectNfsProcedureSetup (DetectEngineCtx *de_ctx, Signature *s, SCLogDebug("low %u hi %u", dd->arg1, dd->arg2); if (SigMatchAppendSMToList(de_ctx, s, DETECT_AL_NFS_PROCEDURE, (SigMatchCtx *)dd, g_nfs_request_buffer_id) == NULL) { - goto error; + DetectNfsProcedureFree(de_ctx, dd); + return -1; } return 0; - -error: - DetectNfsProcedureFree(de_ctx, dd); - return -1; } /** -- 2.47.2