From b3538311b66310cb160569e5bdbcb00e91f4b9aa Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 4 Oct 2023 03:49:22 +0000 Subject: [PATCH] lei: reuse PublicInbox::Config::noop No need to define our own empty `noop' sub when PublicInbox::Config already has one and is loaded anyways. --- lib/PublicInbox/LEI.pm | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm index fba4edf36..c9ad46e2b 100644 --- a/lib/PublicInbox/LEI.pm +++ b/lib/PublicInbox/LEI.pm @@ -1217,8 +1217,6 @@ sub event_step_init { }; } -sub noop {} - sub oldset { $oldset } sub dump_and_clear_log { @@ -1364,15 +1362,9 @@ sub lazy_start { $lis->close; # DS::close }; }; - my $sig = { - CHLD => \&PublicInbox::DS::enqueue_reap, - QUIT => $quit, - INT => $quit, - TERM => $quit, - HUP => \&noop, - USR1 => \&noop, - USR2 => \&noop, - }; + my $sig = { CHLD => \&PublicInbox::DS::enqueue_reap }; + $sig->{$_} = $quit for qw(QUIT INT TERM); + $sig->{$_} = \&PublicInbox::Config::noop for qw(HUP USR1 USR2); # for EVFILT_SIGNAL and signalfd behavioral difference: my @kq_ign = eval { require PublicInbox::DSKQXS } ? keys(%$sig) : (); -- 2.47.2