From b6992818c612fc1bb8666b85056bb8b3d50aaafa Mon Sep 17 00:00:00 2001 From: Cole Robinson Date: Mon, 17 May 2010 11:24:16 -0400 Subject: [PATCH] qemu: Properly cleanup in security startup error path Everything after hostdev setup needs to jump to cleanup on error. --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9612f36274..d5816a4829 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3291,7 +3291,7 @@ static int qemudStartVMDaemon(virConnectPtr conn, if (driver->securityDriver && driver->securityDriver->domainGenSecurityLabel && driver->securityDriver->domainGenSecurityLabel(vm) < 0) - return -1; + goto cleanup; DEBUG0("Generating setting domain security labels (if required)"); if (driver->securityDriver && -- 2.47.2