From b6ecab8541cd5161c1ae319fdd5e7d7ccb45bbdb Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Wed, 6 Dec 2023 11:29:54 +0100 Subject: [PATCH] ukify: add test for --secureboot-certificate-validity= Follow-up for bf35f9c83541785726dce41e54496a07f4841621. --- src/ukify/test/test_ukify.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/ukify/test/test_ukify.py b/src/ukify/test/test_ukify.py index e85171b0e9b..3a60a21f55e 100755 --- a/src/ukify/test/test_ukify.py +++ b/src/ukify/test/test_ukify.py @@ -529,7 +529,8 @@ def test_uname_scraping(kernel_initrd): uname = ukify.Uname.scrape(kernel_initrd[1]) assert re.match(r'\d+\.\d+\.\d+', uname) -def test_efi_signing_sbsign(kernel_initrd, tmpdir): +@pytest.mark.parametrize("days", [365*10, None]) +def test_efi_signing_sbsign(days, kernel_initrd, tmpdir): if kernel_initrd is None: pytest.skip('linux+initrd not found') if not shutil.which('sbsign'): @@ -540,7 +541,7 @@ def test_efi_signing_sbsign(kernel_initrd, tmpdir): key = unbase64(ourdir / 'example.signing.key.base64') output = f'{tmpdir}/signed.efi' - opts = ukify.parse_args([ + args = [ 'build', *kernel_initrd, f'--output={output}', @@ -548,7 +549,11 @@ def test_efi_signing_sbsign(kernel_initrd, tmpdir): '--cmdline=ARG1 ARG2 ARG3', f'--secureboot-certificate={cert.name}', f'--secureboot-private-key={key.name}', - ]) + ] + if days is not None: + args += [f'--secureboot-certificate-validity={days}'] + + opts = ukify.parse_args(args) try: ukify.check_inputs(opts) -- 2.47.3