From b792d9fa57c43f9664fc74c144ab5cc438e31643 Mon Sep 17 00:00:00 2001 From: Eduardo San Martin Morote Date: Fri, 18 Sep 2020 18:53:31 +0200 Subject: [PATCH] refactor: use custom size check --- rollup.config.js | 10 ++++++++-- src/router.ts | 2 +- yarn.lock | 5 +++++ 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/rollup.config.js b/rollup.config.js index d4f14c8c..49086fd1 100644 --- a/rollup.config.js +++ b/rollup.config.js @@ -64,7 +64,10 @@ function createConfig(format, output, plugins = []) { output.sourcemap = !!process.env.SOURCE_MAP output.banner = banner output.externalLiveBindings = false - output.globals = { vue: 'Vue', '@vue/devtools-api': 'VueDevtoolsApi' } + output.globals = { + vue: 'Vue', + '@vue/devtools-api': 'VueDevtoolsApi', + } const isProductionBuild = /\.prod\.js$/.test(output.file) const isGlobalBuild = format === 'global' @@ -94,7 +97,10 @@ function createConfig(format, output, plugins = []) { // during a single build. hasTSChecked = true - const external = ['vue', '@vue/devtools-api'] + const external = [ + 'vue', + // '@vue/devtools-api', + ] const nodePlugins = [resolve(), commonjs()] diff --git a/src/router.ts b/src/router.ts index 9b64f09b..7d5cc326 100644 --- a/src/router.ts +++ b/src/router.ts @@ -1105,7 +1105,7 @@ export function createRouter(options: RouterOptions): Router { unmountApp.call(this, arguments) } - if (__DEV__ && __BROWSER__) { + if ((__DEV__ || __FEATURE_PROD_DEVTOOLS__) && __BROWSER__) { addDevtools(app, router, matcher) } }, diff --git a/yarn.lock b/yarn.lock index 3b2333dd..3a29677c 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1211,6 +1211,11 @@ "@vue/compiler-dom" "3.0.2" "@vue/shared" "3.0.2" +"@vue/devtools-api@^6.0.0-beta.2": + version "6.0.0-beta.2" + resolved "https://registry.yarnpkg.com/@vue/devtools-api/-/devtools-api-6.0.0-beta.2.tgz#833ad3335f97ae9439e26247d97f9baf7b5a6116" + integrity sha512-5k0A8ffjNNukOiceImBdx1e3W5Jbpwqsu7xYHiZVu9mn4rYxFztIt+Q25mOHm7nwvDnMHrE7u5KtY2zmd+81GA== + "@vue/reactivity@3.0.2": version "3.0.2" resolved "https://registry.yarnpkg.com/@vue/reactivity/-/reactivity-3.0.2.tgz#42ed5af6025b494a5e69b05169fcddf04eebfe77" -- 2.39.5