From b7dd507cae8cc2b6fcebdb6791c3259a6de8fbdc Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Tue, 20 Jan 2026 00:20:01 +0900 Subject: [PATCH] tree-wide: use consistent format of short comment for constant argument Follow-ups for recent changes after 93378148d48fa700c7f53b5f8969787af2a47ccb. --- src/basic/process-util.c | 2 +- src/core/bpf-bind-iface.c | 2 +- src/core/unit.c | 2 +- src/shared/dissect-image.c | 6 +++--- src/shared/journal-importer.c | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/basic/process-util.c b/src/basic/process-util.c index c12eae4d422..9c44193b67c 100644 --- a/src/basic/process-util.c +++ b/src/basic/process-util.c @@ -1804,7 +1804,7 @@ int namespace_fork_full( r = pidref_safe_fork_full( outer_name, - /* stdio_fds = */ NULL, /* except_fds = */ NULL, /* n_except_fds = */ 0, + /* stdio_fds= */ NULL, /* except_fds= */ NULL, /* n_except_fds= */ 0, (flags|FORK_DEATHSIG_SIGKILL) & ~(FORK_DEATHSIG_SIGTERM|FORK_DEATHSIG_SIGINT|FORK_REOPEN_LOG|FORK_NEW_MOUNTNS|FORK_MOUNTNS_SLAVE|FORK_NEW_USERNS|FORK_NEW_NETNS|FORK_NEW_PIDNS|FORK_CLOSE_ALL_FDS|FORK_PACK_FDS|FORK_CLOEXEC_OFF|FORK_RLIMIT_NOFILE_SAFE), &pidref_outer); if (r == -EPROTO && FLAGS_SET(flags, FORK_WAIT)) { diff --git a/src/core/bpf-bind-iface.c b/src/core/bpf-bind-iface.c index 6b11e83543f..fdd2e1d8e63 100644 --- a/src/core/bpf-bind-iface.c +++ b/src/core/bpf-bind-iface.c @@ -65,7 +65,7 @@ static int bind_network_interface_install_impl(Unit *u, CGroupRuntime *crt) { if (isempty(cc->bind_network_interface)) return 0; - r = cg_get_path(crt->cgroup_path, /* suffix = */ NULL, &cgroup_path); + r = cg_get_path(crt->cgroup_path, /* suffix= */ NULL, &cgroup_path); if (r < 0) return log_unit_error_errno(u, r, "bind-interface: Failed to get cgroup path: %m"); diff --git a/src/core/unit.c b/src/core/unit.c index 95e52858059..96f56a28e04 100644 --- a/src/core/unit.c +++ b/src/core/unit.c @@ -5582,7 +5582,7 @@ int unit_fork_helper_process_full(Unit *u, const char *name, bool into_cgroup, F } int unit_fork_helper_process(Unit *u, const char *name, bool into_cgroup, PidRef *ret) { - return unit_fork_helper_process_full(u, name, into_cgroup, /* flags = */ 0, ret); + return unit_fork_helper_process_full(u, name, into_cgroup, /* flags= */ 0, ret); } int unit_fork_and_watch_rm_rf(Unit *u, char **paths, PidRef *ret_pid) { diff --git a/src/shared/dissect-image.c b/src/shared/dissect-image.c index 97dc89e5a42..43a6014afef 100644 --- a/src/shared/dissect-image.c +++ b/src/shared/dissect-image.c @@ -471,7 +471,7 @@ static int partition_is_luks2_integrity(int part_fd, uint64_t offset, uint64_t s return log_error_errno(SYNTHETIC_ERRNO(EIO), "Failed to read LUKS JSON header."); json[sz] = '\0'; - r = sd_json_parse(json, /* flags = */ 0, &v, /* reterr_line = */ NULL, /* reterr_column = */ NULL); + r = sd_json_parse(json, /* flags= */ 0, &v, /* reterr_line= */ NULL, /* reterr_column= */ NULL); if (r < 0) return log_error_errno(r, "Failed to parse LUKS JSON header."); @@ -567,7 +567,7 @@ static int dissected_image_probe_filesystems( m->encrypted = true; if (p->mount_node_fd >= 0) - r = partition_is_luks2_integrity(p->mount_node_fd, /* offset = */ 0, /* size = */ UINT64_MAX); + r = partition_is_luks2_integrity(p->mount_node_fd, /* offset= */ 0, /* size= */ UINT64_MAX); else r = partition_is_luks2_integrity(fd, p->offset, p->size); if (r < 0) @@ -1168,7 +1168,7 @@ static int dissect_image( if (verity_settings_data_covers(verity, PARTITION_ROOT)) found_flags = iovec_is_set(&verity->root_hash_sig) ? PARTITION_POLICY_SIGNED : PARTITION_POLICY_VERITY; else if (encrypted) { - r = partition_is_luks2_integrity(fd, /* offset = */ 0, /* size = */ UINT64_MAX); + r = partition_is_luks2_integrity(fd, /* offset= */ 0, /* size= */ UINT64_MAX); if (r < 0) return r; diff --git a/src/shared/journal-importer.c b/src/shared/journal-importer.c index 43681f5d227..3aa472a2d1c 100644 --- a/src/shared/journal-importer.c +++ b/src/shared/journal-importer.c @@ -349,7 +349,7 @@ int journal_importer_process_data(JournalImporter *imp) { return 0; } - /* replace \n with = */ + /* replace '\n' with '=' */ line[n-1] = '='; imp->field_len = n; -- 2.47.3