From b80ab56d10d9907e3dcab8cdcd2285c711201de8 Mon Sep 17 00:00:00 2001 From: Victor Julien Date: Mon, 13 Apr 2020 15:47:18 +0200 Subject: [PATCH] datasets: improve 'dataset-add' error checking --- src/runmode-unix-socket.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/runmode-unix-socket.c b/src/runmode-unix-socket.c index 07c0d52254..355d1305f4 100644 --- a/src/runmode-unix-socket.c +++ b/src/runmode-unix-socket.c @@ -667,6 +667,10 @@ TmEcode UnixSocketDatasetAdd(json_t *cmd, json_t* answer, void *data) SCLogDebug("dataset-add: %s type %s value %s", set_name, type, value); enum DatasetTypes t = DatasetGetTypeFromString(type); + if (t == DATASET_TYPE_NOTSET) { + json_object_set_new(answer, "message", json_string("unknown settype")); + return TM_ECODE_FAILED; + } Dataset *set = DatasetFind(set_name, t); if (set == NULL) { -- 2.47.2