From b889e0904a5449ff7115d95304eea615e9d1f491 Mon Sep 17 00:00:00 2001 From: Amos Jeffries Date: Mon, 2 Jun 2008 05:11:13 -0600 Subject: [PATCH] Fix possible buffer overrun in rfc1738 encoder --- lib/rfc1738.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rfc1738.c b/lib/rfc1738.c index 8e8fbafc67..1ea1a765e7 100644 --- a/lib/rfc1738.c +++ b/lib/rfc1738.c @@ -98,7 +98,7 @@ rfc1738_do_escape(const char *url, int encode_reserved) bufsize = strlen(url) * 3 + 1; buf = xcalloc(bufsize, 1); } - for (p = url, q = buf; *p != '\0'; p++, q++) { + for (p = url, q = buf; *p != '\0' && q < (buf + bufsize - 1); p++, q++) { do_escape = 0; /* RFC 1738 defines these chars as unsafe */ -- 2.47.2