From b96fdcaf857f433fe2ebe4a39448a002dc507e68 Mon Sep 17 00:00:00 2001 From: Evert Timberg Date: Tue, 31 May 2016 22:28:22 -0400 Subject: [PATCH] Docs on new plugin callback --- docs/09-Advanced.md | 5 ++++- src/core/core.controller.js | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/docs/09-Advanced.md b/docs/09-Advanced.md index ff2810f85..2641856c5 100644 --- a/docs/09-Advanced.md +++ b/docs/09-Advanced.md @@ -399,7 +399,10 @@ Plugins should derive from Chart.PluginBase and implement the following interfac // Easing is for animation beforeDraw: function(chartInstance, easing) { }, - afterDraw: function(chartInstance, easing) { } + afterDraw: function(chartInstance, easing) { }, + // Before the datasets are drawn but after scales are drawn + beforeDatasetDraw: function(chartInstance, easing) { }, + afterDatasetDraw: function(chartInstance, easing) { }, destroy: function(chartInstance) { } } diff --git a/src/core/core.controller.js b/src/core/core.controller.js index cc564b65a..195475514 100644 --- a/src/core/core.controller.js +++ b/src/core/core.controller.js @@ -288,7 +288,7 @@ module.exports = function(Chart) { this.scale.draw(); } - Chart.pluginService.notifyPlugins('beforeElementDraw', [this, easingDecimal]); + Chart.pluginService.notifyPlugins('beforeDatasetDraw', [this, easingDecimal]); // Draw each dataset via its respective controller (reversed to support proper line stacking) helpers.each(this.data.datasets, function(dataset, datasetIndex) { @@ -302,7 +302,7 @@ module.exports = function(Chart) { // Finally draw the tooltip this.tooltip.transition(easingDecimal).draw(); - Chart.pluginService.notifyPlugins('afterDraw', [this, easingDecimal]); + Chart.pluginService.notifyPlugins('afterDatasetDraw', [this, easingDecimal]); }, // Get the single element that was clicked on -- 2.47.3