From b985f34f7ae8ce82f8e46d4d09bce451378edeb0 Mon Sep 17 00:00:00 2001 From: Jason Kirtland Date: Fri, 23 May 2008 16:58:20 +0000 Subject: [PATCH] Removed inlining for list.append. --- lib/sqlalchemy/orm/collections.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/sqlalchemy/orm/collections.py b/lib/sqlalchemy/orm/collections.py index 0e27641234..fb1d18895c 100644 --- a/lib/sqlalchemy/orm/collections.py +++ b/lib/sqlalchemy/orm/collections.py @@ -905,12 +905,7 @@ def _list_decorators(): def append(fn): def append(self, item, _sa_initiator=None): - # fully inlining __set and adapter.fire for this critical path - if _sa_initiator is not False and item is not None: - executor = getattr(self, '_sa_adapter', None) - if executor: - executor.attr.fire_append_event(executor.owner_state, - item, _sa_initiator) + __set(self, item, _sa_initiator) fn(self, item) _tidy(append) return append @@ -1347,7 +1342,6 @@ __interfaces = { None: { } } - class MappedCollection(dict): """A basic dictionary-based collection class. -- 2.47.3