From baae6f3ca1c12ecd74eebc0a9ab6d9286a65eb59 Mon Sep 17 00:00:00 2001 From: Jim Jagielski Date: Sun, 18 Nov 2012 13:21:05 +0000 Subject: [PATCH] Document the check in open_logs() git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1410885 13f79535-47bb-0310-9956-ffa450edef68 --- server/mpm/event/fdqueue.c | 1 + server/mpm/eventopt/fdqueue.c | 1 + 2 files changed, 2 insertions(+) diff --git a/server/mpm/event/fdqueue.c b/server/mpm/event/fdqueue.c index 028bca106e1..f4253de343b 100644 --- a/server/mpm/event/fdqueue.c +++ b/server/mpm/event/fdqueue.c @@ -103,6 +103,7 @@ apr_status_t ap_queue_info_set_idle(fd_queue_info_t * queue_info, * TODO: The atomics expect unsigned whereas we're using signed. * Need to double check that they work as expected or else * rework how we determine blocked. + * UPDATE: Correct operation is performed during open_logs() */ prev_idlers = apr_atomic_inc32((apr_uint32_t *)&(queue_info->idlers)); diff --git a/server/mpm/eventopt/fdqueue.c b/server/mpm/eventopt/fdqueue.c index 028bca106e1..f4253de343b 100644 --- a/server/mpm/eventopt/fdqueue.c +++ b/server/mpm/eventopt/fdqueue.c @@ -103,6 +103,7 @@ apr_status_t ap_queue_info_set_idle(fd_queue_info_t * queue_info, * TODO: The atomics expect unsigned whereas we're using signed. * Need to double check that they work as expected or else * rework how we determine blocked. + * UPDATE: Correct operation is performed during open_logs() */ prev_idlers = apr_atomic_inc32((apr_uint32_t *)&(queue_info->idlers)); -- 2.47.2