From bbc663b1c337be1f8bf6d9c3a4e0269cdbfbff9b Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Thu, 24 Jan 2013 18:36:04 +0000 Subject: [PATCH] Fix crash free'ing securityDriverNames in QEMU driver The previous fix to avoid leaking securityDriverNames forgot to handle the case of securityDriverNames being NULL, leading to a crash Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1f43d54978..12769c7fa2 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1134,7 +1134,8 @@ qemuShutdown(void) { VIR_FREE(qemu_driver->saveImageFormat); VIR_FREE(qemu_driver->dumpImageFormat); - for (i = 0 ; qemu_driver->securityDriverNames[i] != NULL ; i++) + for (i = 0 ; (qemu_driver->securityDriverNames != NULL && + qemu_driver->securityDriverNames[i] != NULL) ; i++) VIR_FREE(qemu_driver->securityDriverNames[i]); VIR_FREE(qemu_driver->securityDriverNames); virSecurityManagerFree(qemu_driver->securityManager); -- 2.47.2