From bc17dd4396c1118d0f3043e9430967f7ef9a301f Mon Sep 17 00:00:00 2001 From: Rico Tzschichholz Date: Tue, 15 May 2018 08:17:43 +0200 Subject: [PATCH] codegen: Avoid critical in get_basic_type_info() when there is no signature https://bugzilla.gnome.org/show_bug.cgi?id=729517 --- codegen/valagvariantmodule.vala | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/codegen/valagvariantmodule.vala b/codegen/valagvariantmodule.vala index 7838ea3e9..b6d36b6eb 100644 --- a/codegen/valagvariantmodule.vala +++ b/codegen/valagvariantmodule.vala @@ -61,11 +61,13 @@ public class Vala.GVariantModule : GAsyncModule { return symbol.get_attribute_string ("DBus", "signature"); } - bool get_basic_type_info (string signature, out BasicTypeInfo basic_type) { - foreach (BasicTypeInfo info in basic_types) { - if (info.signature == signature) { - basic_type = info; - return true; + bool get_basic_type_info (string? signature, out BasicTypeInfo basic_type) { + if (signature != null) { + foreach (BasicTypeInfo info in basic_types) { + if (info.signature == signature) { + basic_type = info; + return true; + } } } basic_type = BasicTypeInfo (); -- 2.47.2