From bc1beeb0e413265e5cb6ec8e5cd373ea6f6a3a2a Mon Sep 17 00:00:00 2001 From: Alex Rousskov Date: Wed, 30 Mar 2011 05:53:48 -0600 Subject: [PATCH] Bug 3173: Assertion bodyPipe!=NULL on SslBump CONNECT response writing failure Do not call ConnStateData::startClosing() when we fail to write our CONNECT response while bumping a connection. startClosing() can only be used when we handle response bodies. Just close the connection, in hope that the connection close handler kicks in and cleans up. --- src/client_side_request.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/client_side_request.cc b/src/client_side_request.cc index a0034d9c56..aee8a0cd77 100644 --- a/src/client_side_request.cc +++ b/src/client_side_request.cc @@ -1178,7 +1178,8 @@ ClientHttpRequest::sslBumpEstablish(comm_err_t errflag) return; if (errflag) { - getConn()->startClosing("CONNECT response failure in SslBump"); + debugs(85, 3, HERE << "CONNECT response failure in SslBump: " << errflag); + comm_close(getConn()->fd); return; } -- 2.47.2