From bd5a3e85a0a25e7dda1b48c151f38d722712e70a Mon Sep 17 00:00:00 2001 From: "Michael Matirko (mmatirko)" Date: Tue, 4 Nov 2025 09:43:22 +0000 Subject: [PATCH] Pull request #4970: stream: remove lock on extra_data_log as it is only changed at Analyzer startup Merge in SNORT/snort3 from ~MMATIRKO/snort3:xtra_no_lock to master Squashed commit of the following: commit a59a788ca121a1df8bd111eec08b19e7437dad6b Author: Michael Matirko Date: Mon Nov 3 09:49:45 2025 -0500 stream: remove lock on extra_data_log as it is only changed at Analyzer startup --- src/stream/stream.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/stream/stream.cc b/src/stream/stream.cc index 0611241a7..e0dcea2e4 100644 --- a/src/stream/stream.cc +++ b/src/stream/stream.cc @@ -499,10 +499,9 @@ StreamSplitter* Stream::get_splitter(Flow* flow, bool to_server) void Stream::log_extra_data( Flow* flow, uint32_t mask, const AlertInfo& alert_info) { - std::lock_guard xtra_lock(stream_xtra_mutex); + // coverity[missing_lock] if ( mask && stream.extra_data_log ) { - stream.extra_data_log( flow, stream.extra_data_context, stream.xtradata_map, stream.xtradata_func_count, mask, alert_info); -- 2.47.3