From be00aa971a56b51655e17c57dc20075b42bc8420 Mon Sep 17 00:00:00 2001 From: Peter van Dijk Date: Sun, 21 Feb 2016 19:27:00 +0100 Subject: [PATCH] drop args, use vars like other scripts do, default to assuming they are on PATH --- modules/tinydnsbackend/generate-data.sh | 22 +++++----------------- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/modules/tinydnsbackend/generate-data.sh b/modules/tinydnsbackend/generate-data.sh index eaf08e38fa..d201e90446 100755 --- a/modules/tinydnsbackend/generate-data.sh +++ b/modules/tinydnsbackend/generate-data.sh @@ -2,21 +2,9 @@ set -exu startdir=`pwd` -tcpclient=/usr/bin/tcpclient -axfrget=$1 -tinydnsdata=$2 - -[ -z "$axfrget" ] && axfrget=/service/tinydns/bin/axfr-get -[ -z "$tinydnsdata" ] && tinydnsdata=/service/tinydns/bin/tinydns-data - - - -if [ ! -x $axfrget ] || [ "$axfrget" = help ] || [ ! -x $tinydnsdata ] || [ "$tinydnsdata" = help ] -then - echo "Usage: ./generate-data.sh "; - exit 1 -fi - +TCPCLIENT=${TCPCLIENT:-tcpclient} +AXFRGET=${AXFRGET:-axfr-get} +TINYDNSDATA=${TINYDNSDATA:-tinydns-data} # Copy original zones because the test might modify them (well only the dyndns stuff, but let's make this work for others as well) for zone in $(grep 'zone ' ../../regression-tests/named.conf | cut -f2 -d\") @@ -45,11 +33,11 @@ cd $startdir for zone in $(grep 'zone ' ../../regression-tests/named.conf | cut -f2 -d\") do - $tcpclient 127.0.0.1 5300 $axfrget $zone $zone.out $zone.out.tmp + $TCPCLIENT 127.0.0.1 5300 $AXFRGET $zone $zone.out $zone.out.tmp cat $zone.out >> data rm $zone.out done -$tinydnsdata +$TINYDNSDATA kill $(cat ../../regression-tests/pdns.pid) -- 2.47.2