From be336620b7cee3ebf06186352748e1ebac5830ae Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Wed, 19 Apr 2023 10:41:55 +0200 Subject: [PATCH] BUG/MINOR: cfgparse: make sure to include openssl-compat Commit 5003ac7fe ("MEDIUM: config: set useful ALPN defaults for HTTPS and QUIC") revealed a build dependency bug: if QUIC is not enabled, cfgparse doesn't have any dependency on the SSL stack, so the various ifdefs that try to check special conditions such as rejecting an H2 config with too small a bufsize, are silently ignored. This was detected because the default ALPN string was not set and caused the alpn regtest to fail without QUIC support. Adding openssl-compat to the list of includes seems to be sufficient to have what we need. It's unclear when this dependency was broken, it seems that even 2.2 didn't have an explicit dependency on anything SSL-related, though it could have been inherited through other files (as happens with QUIC here). It would be safe to backport it to all stable branches. The impact is very low anyway. --- src/cfgparse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cfgparse.c b/src/cfgparse.c index 72dde1ea6e..f229e3b6b0 100644 --- a/src/cfgparse.c +++ b/src/cfgparse.c @@ -71,6 +71,7 @@ #include #include #include +#include #include #include #include -- 2.47.3