From be6b40b024d38b64ca515be3087a5a39db0f867b Mon Sep 17 00:00:00 2001 From: Andrey Volk Date: Thu, 21 Jan 2021 18:43:02 +0300 Subject: [PATCH] [mod_lcr] Fix order_by and sql_stream streams leaking in the case of a DB error in lcr_load_config() --- src/mod/applications/mod_lcr/mod_lcr.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/mod/applications/mod_lcr/mod_lcr.c b/src/mod/applications/mod_lcr/mod_lcr.c index a9adb3db10..ab7c163ce5 100644 --- a/src/mod/applications/mod_lcr/mod_lcr.c +++ b/src/mod/applications/mod_lcr/mod_lcr.c @@ -1186,6 +1186,8 @@ static switch_status_t lcr_load_config() if (db_check("ALTER TABLE carrier_gateway add codec varchar(255);") == SWITCH_TRUE) { switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_NOTICE, "adding codec field your lcr carrier_gateway database schema.\n"); } else { + switch_safe_free(order_by.data); + switch_safe_free(sql_stream.data); switch_goto_status(SWITCH_STATUS_FALSE, done); } } @@ -1197,6 +1199,8 @@ static switch_status_t lcr_load_config() if (db_check("ALTER TABLE lcr add cid varchar(32);") == SWITCH_TRUE) { switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_WARNING, "adding cid field to your lcr database schema.\n"); } else { + switch_safe_free(order_by.data); + switch_safe_free(sql_stream.data); switch_goto_status(SWITCH_STATUS_FALSE, done); } } @@ -1205,6 +1209,8 @@ static switch_status_t lcr_load_config() if (db_check("ALTER TABLE lcr ADD lrn BOOLEAN NOT NULL DEFAULT false")) { switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_WARNING, "adding lrn field to your lcr database schema.\n"); } else { + switch_safe_free(order_by.data); + switch_safe_free(sql_stream.data); switch_goto_status(SWITCH_STATUS_FALSE, done); } } -- 2.47.2