From beb6d2de65281e86cc643d796f98a9b6045765e3 Mon Sep 17 00:00:00 2001 From: Adhemerval Zanella Date: Mon, 21 Apr 2025 15:12:21 -0300 Subject: [PATCH] math: Fix UB in setayload The code can shift the 1ULL for value larger than 63 depending of the exponent value. Add a check prior the shift. --- sysdeps/ieee754/dbl-64/s_setpayload_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sysdeps/ieee754/dbl-64/s_setpayload_main.c b/sysdeps/ieee754/dbl-64/s_setpayload_main.c index 779371837c..2c6c946ae7 100644 --- a/sysdeps/ieee754/dbl-64/s_setpayload_main.c +++ b/sysdeps/ieee754/dbl-64/s_setpayload_main.c @@ -37,7 +37,9 @@ FUNC (double *x, double payload) except for 0 when allowed; (c) not an integer. */ if (exponent >= BIAS + PAYLOAD_DIG || (exponent < BIAS && !(SET_HIGH_BIT && ix == 0)) - || (ix & ((1ULL << (BIAS + EXPLICIT_MANT_DIG - exponent)) - 1)) != 0) + || ((BIAS + EXPLICIT_MANT_DIG - exponent) < 64 + && (ix & ((1ULL << (BIAS + EXPLICIT_MANT_DIG - exponent)) - 1)) + != 0)) { INSERT_WORDS64 (*x, 0); return 1; -- 2.47.2