From bec695f3ec43972ad38f06f92ff2db03d8405562 Mon Sep 17 00:00:00 2001 From: Dwight Engen Date: Fri, 3 May 2013 12:04:07 -0400 Subject: [PATCH] coverity: fix leak when ipv6 gw is auto Signed-off-by: Dwight Engen Signed-off-by: Serge Hallyn --- src/lxc/confile.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/lxc/confile.c b/src/lxc/confile.c index d0a404f4a..fbae861bf 100644 --- a/src/lxc/confile.c +++ b/src/lxc/confile.c @@ -782,12 +782,6 @@ static int config_network_ipv6_gateway(const char *key, const char *value, if (!netdev) return -1; - gw = malloc(sizeof(*gw)); - if (!gw) { - SYSERROR("failed to allocate ipv6 gateway address"); - return -1; - } - if (!value) { ERROR("no ipv6 gateway address specified"); return -1; @@ -797,6 +791,12 @@ static int config_network_ipv6_gateway(const char *key, const char *value, netdev->ipv6_gateway = NULL; netdev->ipv6_gateway_auto = true; } else { + gw = malloc(sizeof(*gw)); + if (!gw) { + SYSERROR("failed to allocate ipv6 gateway address"); + return -1; + } + if (!inet_pton(AF_INET6, value, gw)) { SYSERROR("invalid ipv6 gateway address: %s", value); free(gw); -- 2.47.2