From bf11f6f06c687a010a0c9fc489291cc86f88122f Mon Sep 17 00:00:00 2001 From: Richard Gibson Date: Wed, 17 Oct 2018 09:25:55 -0400 Subject: [PATCH] dnsdist: Refactor overflow-unsafe comparisons --- pdns/dnsdist-lua-bindings-dnsquestion.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pdns/dnsdist-lua-bindings-dnsquestion.cc b/pdns/dnsdist-lua-bindings-dnsquestion.cc index 2c7d774169..dbbb6cdba9 100644 --- a/pdns/dnsdist-lua-bindings-dnsquestion.cc +++ b/pdns/dnsdist-lua-bindings-dnsquestion.cc @@ -73,7 +73,7 @@ void setupLuaBindingsDNSQuestion() char* message = reinterpret_cast(dq.dh); const uint16_t messageLen = getDNSPacketLength(message, dq.len); const uint16_t tailLen = tail.size(); - if(messageLen + tailLen > dq.size) { + if(tailLen > (dq.size - messageLen)) { return false; } @@ -154,7 +154,7 @@ void setupLuaBindingsDNSQuestion() char* message = reinterpret_cast(dq.dh); const uint16_t messageLen = getDNSPacketLength(message, dq.len); const uint16_t tailLen = tail.size(); - if(messageLen + tailLen > dq.size) { + if(tailLen > (dq.size - messageLen)) { return false; } -- 2.47.2