From bf6c900db7ec99d7b0b4bd6e007acb541ca848d4 Mon Sep 17 00:00:00 2001 From: Christophe Jaillet Date: Mon, 21 Feb 2022 21:07:35 +0000 Subject: [PATCH] There is no point in calling ap_varbuf_grow() here, it is already called from within ap_varbuf_strmemcat(). Moreover, 2nd parameter should be the minimum total new length, not the amount of the growth. So this call is likely to be a no-op. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1898286 13f79535-47bb-0310-9956-ffa450edef68 --- server/util_expr_eval.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/server/util_expr_eval.c b/server/util_expr_eval.c index 823978d2f34..9c71e865b0f 100644 --- a/server/util_expr_eval.c +++ b/server/util_expr_eval.c @@ -14,7 +14,7 @@ * limitations under the License. */ -/* _ _ +/* * ap_expr_eval.c, based on ssl_expr_eval.c from mod_ssl */ @@ -124,7 +124,6 @@ static const char *ap_expr_list_pstrcat(apr_pool_t *p, for (i = 0; i < n; ++i) { val = APR_ARRAY_IDX(list, i, const char*); vlen = strlen(val); - ap_varbuf_grow(&vb, vlen + slen + 1); ap_varbuf_strmemcat(&vb, val, vlen); ap_varbuf_strmemcat(&vb, sep, slen); } -- 2.47.2