From c02f952b48927af9fc4e991d7ead89a4cd1636bc Mon Sep 17 00:00:00 2001 From: Georgi Valkov Date: Sat, 4 May 2024 11:24:08 +0300 Subject: [PATCH] quic_multistream_test: fix undefined symbol snprintf with VS2010 As snprintf is not available everywhere, use BIO_snprintf instead. Fixes: IF EXIST test\quic_multistream_test.exe.manifest DEL /F /Q test\quic_multistream_test.exe.manifest "link" /nologo /debug setargv.obj /subsystem:console /opt:ref /nologo /debug @V:\_tmp\nm4.tmp quic_multistream_test-bin-quic_multistream_test.obj : error LNK2019: unresolved external symbol _snprintf referenced in function _helper_init test\quic_multistream_test.exe : fatal error LNK1120: 1 unresolved externals NMAKE : fatal error U1077: '"E:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\BIN\link.EXE"' : return code '0x460' Signed-off-by: Georgi Valkov Reviewed-by: Paul Dale Reviewed-by: Tom Cosgrove Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/24369) --- test/quic_multistream_test.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/quic_multistream_test.c b/test/quic_multistream_test.c index e01e8ae85a3..2d1087266e6 100644 --- a/test/quic_multistream_test.c +++ b/test/quic_multistream_test.c @@ -784,7 +784,7 @@ static int helper_init(struct helper *h, const char *script_name, goto err; /* Set title for qlog purposes. */ - snprintf(title, sizeof(title), "quic_multistream_test: %s", script_name); + BIO_snprintf(title, sizeof(title), "quic_multistream_test: %s", script_name); if (!TEST_true(ossl_quic_set_diag_title(h->c_ctx, title))) goto err; @@ -5827,7 +5827,7 @@ static int test_script(int idx) } #endif - snprintf(script_name, sizeof(script_name), "script %d", script_idx + 1); + BIO_snprintf(script_name, sizeof(script_name), "script %d", script_idx + 1); TEST_info("Running script %d (order=%d, blocking=%d)", script_idx + 1, free_order, blocking); @@ -5912,8 +5912,8 @@ static ossl_unused int test_dyn_frame_types(int idx) s[i].arg2 = forbidden_frame_types[idx].expected_err; } - snprintf(script_name, sizeof(script_name), - "dyn script %d", idx); + BIO_snprintf(script_name, sizeof(script_name), + "dyn script %d", idx); return run_script(dyn_frame_types_script, script_name, 0, 0); } -- 2.47.3