From c101092adfdfc794ca68be32616340405ae7be07 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 5 Mar 2010 16:18:47 +0100 Subject: [PATCH] virInterfaceDefParseBond: avoid dead stores * src/conf/interface_conf.c (virInterfaceDefParseBond): Avoid dead stores to local, "node". Remove declaration, too. --- src/conf/interface_conf.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index a0d2dfabc3..f60b36a9d0 100644 --- a/src/conf/interface_conf.c +++ b/src/conf/interface_conf.c @@ -570,7 +570,6 @@ error: static int virInterfaceDefParseBond(virInterfaceDefPtr def, xmlXPathContextPtr ctxt) { - xmlNodePtr node; int ret = -1; unsigned long tmp; @@ -582,8 +581,7 @@ virInterfaceDefParseBond(virInterfaceDefPtr def, if (ret != 0) goto error; - node = virXPathNode("./miimon[1]", ctxt); - if (node != NULL) { + if (virXPathNode("./miimon[1]", ctxt) != NULL) { def->data.bond.monit = VIR_INTERFACE_BOND_MONIT_MII; ret = virXPathULong("string(./miimon/@freq)", ctxt, &tmp); @@ -618,7 +616,7 @@ virInterfaceDefParseBond(virInterfaceDefPtr def, goto error; } - } else if ((node = virXPathNode("./arpmon[1]", ctxt)) != NULL) { + } else if (virXPathNode("./arpmon[1]", ctxt) != NULL) { def->data.bond.monit = VIR_INTERFACE_BOND_MONIT_ARP; -- 2.47.2