From c1cc1f4b5e77d0598bec6e91dc34775ce25e7ef5 Mon Sep 17 00:00:00 2001 From: Paul Floyd Date: Sat, 18 Nov 2023 08:23:08 +0100 Subject: [PATCH] freebsd: unused variable warning still not sure what to do in aio_cancel --- coregrind/m_syswrap/syswrap-freebsd.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/coregrind/m_syswrap/syswrap-freebsd.c b/coregrind/m_syswrap/syswrap-freebsd.c index dab12a6eac..9371fed0f1 100644 --- a/coregrind/m_syswrap/syswrap-freebsd.c +++ b/coregrind/m_syswrap/syswrap-freebsd.c @@ -3012,14 +3012,17 @@ PRE(sys_aio_cancel) } else { if (ARG2) { if (ML_(safe_to_deref)((struct vki_aiocb *)ARG2, sizeof(struct vki_aiocb))) { - struct vki_aiocb *iocb = (struct vki_aiocb *)ARG2; + // struct vki_aiocb *iocb = (struct vki_aiocb *)ARG2; // @todo PJF cancel only requests associated with // fildes and iocb + // Do I need to remove pending reads from iocb(v)_table + // or should the user always call aio_return even after + // aio_cancel? } else { SET_STATUS_Failure(VKI_EINVAL); } } else { - // @todo PJF cancel all requests associated with fildes + // @todo PJF cancel all requests associated with fildes, see above } } } -- 2.47.2