From c1f27d21213f05bd4656e24ec5a5a076ebaa6afd Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 3 Nov 2023 20:25:07 +0000 Subject: [PATCH] lei_view_text: fix inverted condition This was causing `lei q -f text' output to be uncolored on color-capable terminals. Fixes: d3c55d072839 (treewide: use ->close to call ProcessIO->CLOSE) --- lib/PublicInbox/LeiViewText.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/LeiViewText.pm b/lib/PublicInbox/LeiViewText.pm index ce9f248ea..c7d72c71c 100644 --- a/lib/PublicInbox/LeiViewText.pm +++ b/lib/PublicInbox/LeiViewText.pm @@ -75,7 +75,7 @@ sub new { my @cmd = qw(git config -z --includes -l); # reuse normal git config my $r = popen_rd(\@cmd, undef, { 2 => $lei->{2} }); my $cfg = PublicInbox::Config::config_fh_parse($r, "\0", "\n"); - if ($r->close) { + if (!$r->close) { warn "# @cmd failed, no color (non-fatal \$?=$?)\n"; return $self; } -- 2.47.2