From c270fc448ea82ff1aa3af08f15fe7aa39fddb52e Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Wed, 11 Oct 2023 16:59:24 +0200 Subject: [PATCH] varlink: don't bother replying about validation errors on method calls with 'oneway' set --- src/shared/varlink.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/shared/varlink.c b/src/shared/varlink.c index 8eeac4a49fd..8f643e27b0f 100644 --- a/src/shared/varlink.c +++ b/src/shared/varlink.c @@ -1314,7 +1314,12 @@ static int varlink_dispatch_method(Varlink *v) { r = varlink_idl_validate_method_call(v->current_method, parameters, &bad_field); if (r < 0) { log_debug_errno(r, "Parameters for method %s() didn't pass validation on field '%s': %m", method, strna(bad_field)); - r = varlink_errorb(v, VARLINK_ERROR_INVALID_PARAMETER, JSON_BUILD_OBJECT(JSON_BUILD_PAIR_STRING("parameter", bad_field))); + + if (!FLAGS_SET(flags, VARLINK_METHOD_ONEWAY)) { + r = varlink_errorb(v, VARLINK_ERROR_INVALID_PARAMETER, JSON_BUILD_OBJECT(JSON_BUILD_PAIR_STRING("parameter", bad_field))); + if (r < 0) + return r; + } invalid = true; } } -- 2.47.3