From c29c5ed2966425a14aab6794e739a78ab46178a5 Mon Sep 17 00:00:00 2001 From: Andrew Goodbody Date: Tue, 8 Jul 2025 17:51:17 +0100 Subject: [PATCH] net: Incorrect NOP macro used for test In tcp_parse_options the uchar p[0] is attempted to test for a match with the 32bit macro TCP_0_NOP which can never be true. Instead test against the 8bit macro TCP_1_NOP. This issue found by Smatch. Signed-off-by: Andrew Goodbody Reviewed-by: Jerome Forissier --- net/tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tcp.c b/net/tcp.c index 2635727f47d..8740150365f 100644 --- a/net/tcp.c +++ b/net/tcp.c @@ -804,7 +804,7 @@ void tcp_parse_options(struct tcp_stream *tcp, uchar *o, int o_len) } /* Process optional NOPs */ - if (p[0] == TCP_O_NOP) + if (p[0] == TCP_1_NOP) p++; else p += p[1]; -- 2.47.2