From c3600e9b5991e00d8cf8b29aec4d3005fb311f84 Mon Sep 17 00:00:00 2001 From: Marco Baffo Date: Fri, 12 Sep 2025 15:15:19 +0200 Subject: [PATCH] push-update-server: comment about buf_string_compare_advance() usage in send_single_push_update() Change-Id: I73f8ad9bf105920f4bde357ea9dcf0e485f3f3cb Signed-off-by: Marco Baffo Acked-by: Frank Lichtenheld Message-Id: <20250912131519.43222-1-frank@lichtenheld.com> URL: https://sourceforge.net/p/openvpn/mailman/message/59232447/ URL: https://gerrit.openvpn.net/c/openvpn/+/1177 Signed-off-by: Gert Doering --- src/openvpn/push_util.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/openvpn/push_util.c b/src/openvpn/push_util.c index bd3992be6..f7a4fca6f 100644 --- a/src/openvpn/push_util.c +++ b/src/openvpn/push_util.c @@ -161,6 +161,10 @@ send_single_push_update(struct context *c, struct buffer *msgs, unsigned int *op * will not be routed towards the client. * For the same reason we later update the vhash too in * `send_push_update()` function. + * Using `buf_string_compare_advance()` we mimic the behavior + * inside `process_incoming_push_msg()`. However, we don't need + * to check the return value here because we just want to `advance`, + * meaning we skip the `push_update_cmd' we added earlier. */ buf_string_compare_advance(&msgs[i], push_update_cmd); if (process_incoming_push_update(c, pull_permission_mask(c), option_types_found, &msgs[i], true) == PUSH_MSG_ERROR) -- 2.47.3