From c382ea6f63d893d94ac6b6adc2cb32028911a2ff Mon Sep 17 00:00:00 2001 From: Philip Jenvey Date: Tue, 21 Jul 2009 21:07:04 +0000 Subject: [PATCH] close connections --- lib/sqlalchemy/test/testing.py | 7 ++++--- test/engine/test_transaction.py | 13 +++++++++---- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/lib/sqlalchemy/test/testing.py b/lib/sqlalchemy/test/testing.py index cdc6c05092..4a265fbec6 100644 --- a/lib/sqlalchemy/test/testing.py +++ b/lib/sqlalchemy/test/testing.py @@ -281,9 +281,10 @@ def _server_version(bind=None): bind = config.db # force metadata to be retrieved - bind.connect() - - return getattr(bind.dialect, 'server_version_info', ()) + conn = bind.connect() + version = getattr(bind.dialect, 'server_version_info', ()) + conn.close() + return version def skip_if(predicate, reason=None): """Skip a test if predicate is true.""" diff --git a/test/engine/test_transaction.py b/test/engine/test_transaction.py index f344186655..4ac0e6134d 100644 --- a/test/engine/test_transaction.py +++ b/test/engine/test_transaction.py @@ -20,7 +20,8 @@ class TransactionTest(TestBase): users.create(testing.db) def teardown(self): - testing.db.connect().execute(users.delete()) + testing.db.connect().execute(users.delete()).close() + @classmethod def teardown_class(cls): users.drop(testing.db) @@ -383,7 +384,7 @@ class ExplicitAutoCommitTest(TestBase): testing.db.execute("create function insert_foo(varchar) returns integer as 'insert into foo(data) values ($1);select 1;' language sql") def teardown(self): - foo.delete().execute() + foo.delete().execute().close() @classmethod def teardown_class(cls): @@ -456,8 +457,10 @@ class TLTransactionTest(TestBase): test_needs_acid=True, ) users.create(tlengine) + def teardown(self): - tlengine.execute(users.delete()) + tlengine.execute(users.delete()).close() + @classmethod def teardown_class(cls): users.drop(tlengine) @@ -723,8 +726,10 @@ class ForUpdateTest(TestBase): test_needs_acid=True, ) counters.create(testing.db) + def teardown(self): - testing.db.connect().execute(counters.delete()) + testing.db.connect().execute(counters.delete()).close() + @classmethod def teardown_class(cls): counters.drop(testing.db) -- 2.47.3