From c40679fbb051228f6c5108adaa9f6fc6929b1e0f Mon Sep 17 00:00:00 2001 From: Antonio Quartulli Date: Mon, 20 Apr 2020 12:21:02 +0200 Subject: [PATCH] remove bogus file check on --genkey argument When invoking openvpn as standalone with the --genkey argument, options_postprocess() is not called at all because do_genkey() takes over the execution earlier. For this reason, checking the --genkey argument in options_postprocess_filechecks() is a no-op. Geti rid of the bogus check altogether. Signed-off-by: Antonio Quartulli Acked-by: Gert Doering Message-Id: <20200420102102.20981-1-a@unstable.cc> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19795.html Signed-off-by: Gert Doering --- src/openvpn/options.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 63dc53c3c..a8394c6c3 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -3420,9 +3420,6 @@ options_postprocess_filechecks(struct options *options) "--tls-crypt-v2"); } - errs |= check_file_access(CHKACC_FILE|CHKACC_INLINE|CHKACC_PRIVATE, - options->genkey_filename, R_OK, - "--genkey"); errs |= check_file_access(CHKACC_FILE|CHKACC_INLINE|CHKACC_PRIVATE, options->shared_secret_file, R_OK, "--secret"); -- 2.47.2