From c44cfe7d1ef46b4a659803573150bbb8ff1a7f60 Mon Sep 17 00:00:00 2001 From: Andrew Novikov Date: Sun, 9 Jul 2023 02:05:56 +0000 Subject: [PATCH] Bug 5187: Work around REQMOD satisfaction regression (#1400) Commit ba3fe8d broke ICAP REQMOD satisfaction transactions. In some cases, this workaround may resurrect Squid Bug 5187. Triage available at https://bugs.squid-cache.org/show_bug.cgi?id=5187#c6 --- src/client_side_request.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/client_side_request.cc b/src/client_side_request.cc index dc2c3d1a48..8affab7b2f 100644 --- a/src/client_side_request.cc +++ b/src/client_side_request.cc @@ -2057,8 +2057,13 @@ ClientHttpRequest::noteMoreBodyDataAvailable(BodyPipe::Pointer) bpc.checkIn(); } - if (adaptedBodySource->exhausted()) + if (adaptedBodySource->exhausted()) { + // XXX: Setting receivedWholeAdaptedReply here is a workaround for a + // regression, as described in https://bugs.squid-cache.org/show_bug.cgi?id=5187#c6 + receivedWholeAdaptedReply = true; + debugs(85, DBG_IMPORTANT, "WARNING: Squid bug 5187 workaround triggered"); endRequestSatisfaction(); + } // else wait for more body data } -- 2.47.2