From c46bdad5768da39bbccaa66c5c63f7303e56ad49 Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Mon, 27 May 2019 11:07:12 +0200 Subject: [PATCH] qemu: Get default hugepage size only if needed Fixes: 6864d8f740e2502dc7625bdf18ffde4465b14f69 Hugepages don't work in session mode but when building memory part of command line we query for the default size anyway. This breaks creating domains under session daemon. Query the page size only if it's clear we need hugepages. Signed-off-by: Michal Privoznik Reviewed-by: Erik Skultety --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 73f570c419..5bf6c704e0 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3573,7 +3573,7 @@ qemuBuildMemoryBackendProps(virJSONValuePtr *backendProps, pagesize = 0; needHugepage = false; useHugepage = false; - } else if (pagesize == 0) { + } else if (useHugepage && pagesize == 0) { if (qemuBuildMemoryGetDefaultPagesize(cfg, &pagesize) < 0) goto cleanup; } -- 2.47.2