From c5340d5420012412ea298f0102cc7f113e87d89b Mon Sep 17 00:00:00 2001 From: Martin Kletzander Date: Fri, 20 Jan 2023 10:28:52 +0100 Subject: [PATCH] qemuDomainAttachWatchdog: Avoid unnecessary nesting Signed-off-by: Martin Kletzander Reviewed-by: Michal Privoznik --- src/qemu/qemu_hotplug.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 070e0a051c..e153e4806d 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -2936,17 +2936,17 @@ qemuDomainAttachWatchdog(virDomainObj *vm, qemuAssignDeviceWatchdogAlias(watchdog); - if (watchdog->model == VIR_DOMAIN_WATCHDOG_MODEL_I6300ESB) { - if (qemuDomainEnsurePCIAddress(vm, &dev) < 0) - goto cleanup; - releaseAddress = true; - } else { + if (watchdog->model != VIR_DOMAIN_WATCHDOG_MODEL_I6300ESB) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, _("hotplug of watchdog of model %s is not supported"), virDomainWatchdogModelTypeToString(watchdog->model)); goto cleanup; } + if (qemuDomainEnsurePCIAddress(vm, &dev) < 0) + goto cleanup; + releaseAddress = true; + if (!(props = qemuBuildWatchdogDevProps(vm->def, watchdog))) goto cleanup; -- 2.47.2