From c730fd7ddd222b03fe3c0dae77c64131b5ac49b9 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Wed, 14 May 2025 15:09:09 +0200 Subject: [PATCH] elf2efi: make code more pythonic Follow-up for 53628612b75b444681fabc729ad7b012299c4c63. With 'or', we ignore the empty string (but not '0'), and we only call time.time() lazily. So this works the same as the code that is replaced, but avoids the ugly repetition. --- tools/elf2efi.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/elf2efi.py b/tools/elf2efi.py index fff2b1a4be4..d3ef5907b20 100755 --- a/tools/elf2efi.py +++ b/tools/elf2efi.py @@ -611,9 +611,7 @@ def elf2efi(args: argparse.Namespace): coff.Machine = pe_arch coff.NumberOfSections = len(sections) - coff.TimeDateStamp = int( - os.environ.get("SOURCE_DATE_EPOCH") if os.environ.get("SOURCE_DATE_EPOCH") else time.time() - ) + coff.TimeDateStamp = int(os.environ.get("SOURCE_DATE_EPOCH") or time.time()) coff.SizeOfOptionalHeader = sizeof(opt) # EXECUTABLE_IMAGE|LINE_NUMS_STRIPPED|LOCAL_SYMS_STRIPPED|DEBUG_STRIPPED # and (32BIT_MACHINE or LARGE_ADDRESS_AWARE) -- 2.47.3