From c732c5985a690c452784b28b4c38492a3d6452e9 Mon Sep 17 00:00:00 2001 From: Christos Tsantilas Date: Tue, 2 Oct 2012 19:15:40 +0300 Subject: [PATCH] - Fix a memory leak in FwdState::sslCrtvdCheckForErrors method: The allocated ACLFilledChecklist object should released before leave this method polish code a little: * debuging messages fix * Fix debug section in ssl/helper.cc file --- src/forward.cc | 4 +++- src/ssl/helper.cc | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/forward.cc b/src/forward.cc index a17daf14de..638bdbc68a 100644 --- a/src/forward.cc +++ b/src/forward.cc @@ -826,7 +826,7 @@ FwdState::sslCrtvdHandleReply(const char *reply) SSL *ssl = fd_table[serverConnection()->fd].ssl; if (!reply) { - debugs(83, 1, HERE << "\"ssl_crtd\" helper return reply"); + debugs(83, 1, HERE << "\"ssl_crtvd\" helper return reply"); validatorFailed = true; } else { Ssl::CertValidationMsg replyMsg; @@ -936,6 +936,8 @@ FwdState::sslCrtvdCheckForErrors(Ssl::CertValidationResponse &resp, Ssl::ErrorDe else errs->push_back_unique(i->error_no); } + if (check) + delete check; return errs; } diff --git a/src/ssl/helper.cc b/src/ssl/helper.cc index 48459f73b2..d42db1c730 100644 --- a/src/ssl/helper.cc +++ b/src/ssl/helper.cc @@ -178,7 +178,7 @@ void Ssl::CertValidationHelper::sslSubmit(CrtdMessage const & message, HLPCB * c first_warn = squid_curtime; if (squid_curtime - first_warn > 3 * 60) fatal("SSL servers not responding for 3 minutes"); - debugs(34, 1, HERE << "Queue overload, rejecting"); + debugs(83, 1, HERE << "Queue overload, rejecting"); callback(data, (char *)"error 45 Temporary network problem, please retry later"); return; } -- 2.47.3