From c75f4b5c34e4aaec804c32cd44a4cfb0ce32fdfc Mon Sep 17 00:00:00 2001 From: Guinevere Larsen Date: Wed, 23 Jul 2025 09:06:22 -0300 Subject: [PATCH] gdb: use the location_completer for the list command The "location_completer" function has been available for a long time, but it was seemingly never used as the completer for the list function. A quick check through git history shows that a similar completer was available for the "edit" command but wasn't added to "list" with no reasoning for it. I think "list" should use the location_completer, as it is more aware of the locspec grammar. Approved-By: Tom Tromey --- gdb/cli/cli-cmds.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c index 5e887f5ceac..868f12c23b0 100644 --- a/gdb/cli/cli-cmds.c +++ b/gdb/cli/cli-cmds.c @@ -2898,6 +2898,7 @@ This can be changed using \"set listsize\", and the current value\n\ can be shown using \"show listsize\".")); add_com_alias ("l", list_cmd, class_files, 1); + set_cmd_completer(list_cmd, location_completer); c = add_com ("disassemble", class_vars, disassemble_command, _("\ Disassemble a specified section of memory.\n\ -- 2.47.2