From c780438d32b674c825f355fdecc0a012e3e7652f Mon Sep 17 00:00:00 2001 From: Zoltan Kiss Date: Fri, 18 Jul 2014 19:08:05 +0100 Subject: [PATCH] xen-netback: Fix pointer incrementation to avoid incorrect logging [ Upstream commit d8cfbfc4660054150ca1b7c501a8edc0771022f9 ] Due to this pointer is increased prematurely, the error log contains rubbish. Signed-off-by: Zoltan Kiss Reported-by: Armin Zentai Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-devel@lists.xenproject.org Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/xen-netback/netback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 2c5a6f9f61d81..034645a2978f6 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -1022,7 +1022,6 @@ static int xenvif_tx_check_gop(struct xenvif *vif, /* Check status of header. */ err = (*gopp_copy)->status; - (*gopp_copy)++; if (unlikely(err)) { if (net_ratelimit()) netdev_dbg(vif->dev, @@ -1035,6 +1034,7 @@ static int xenvif_tx_check_gop(struct xenvif *vif, xenvif_idx_release(vif, pending_idx, XEN_NETIF_RSP_ERROR); } + (*gopp_copy)++; check_frags: for (i = 0; i < nr_frags; i++, gop_map++) { -- 2.47.2