From c89bf37f64e30134a2eb4010870e72fc3bbf107d Mon Sep 17 00:00:00 2001
From: Miod Vallat <miod.vallat@powerdns.com>
Date: Fri, 25 Jul 2025 11:10:32 +0200
Subject: [PATCH] Address clang-tidy complains.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
---
 pdns/misc.cc        | 21 ++++++++++++++-------
 pdns/resolver.cc    |  6 ++++--
 pdns/tcpreceiver.cc |  6 ++++--
 3 files changed, 22 insertions(+), 11 deletions(-)

diff --git a/pdns/misc.cc b/pdns/misc.cc
index 5fa254c1c..f8ccfa82d 100644
--- a/pdns/misc.cc
+++ b/pdns/misc.cc
@@ -1375,20 +1375,27 @@ uint64_t getCPUSteal(const std::string& /* str */)
 
 bool getTSIGHashEnum(const DNSName& algoName, TSIGHashEnum& algoEnum)
 {
-  if (algoName == g_hmacmd5dnsname_long || algoName == g_hmacmd5dnsname)
+  if (algoName == g_hmacmd5dnsname_long || algoName == g_hmacmd5dnsname) {
     algoEnum = TSIG_MD5;
-  else if (algoName == g_hmacsha1dnsname)
+  }
+  else if (algoName == g_hmacsha1dnsname) {
     algoEnum = TSIG_SHA1;
-  else if (algoName == g_hmacsha224dnsname)
+  }
+  else if (algoName == g_hmacsha224dnsname) {
     algoEnum = TSIG_SHA224;
-  else if (algoName == g_hmacsha256dnsname)
+  }
+  else if (algoName == g_hmacsha256dnsname) {
     algoEnum = TSIG_SHA256;
-  else if (algoName == g_hmacsha384dnsname)
+  }
+  else if (algoName == g_hmacsha384dnsname) {
     algoEnum = TSIG_SHA384;
-  else if (algoName == g_hmacsha512dnsname)
+  }
+  else if (algoName == g_hmacsha512dnsname) {
     algoEnum = TSIG_SHA512;
-  else if (algoName == g_gsstsigdnsname)
+  }
+  else if (algoName == g_gsstsigdnsname) {
     algoEnum = TSIG_GSS;
+  }
   else {
      return false;
   }
diff --git a/pdns/resolver.cc b/pdns/resolver.cc
index 3b51ff09e..7baede556 100644
--- a/pdns/resolver.cc
+++ b/pdns/resolver.cc
@@ -144,10 +144,12 @@ uint16_t Resolver::sendResolve(const ComboAddress& remote, const ComboAddress& l
   if(!tsigkeyname.empty()) {
     // cerr<<"Adding TSIG to notification, key name: '"<<tsigkeyname<<"', algo: '"<<tsigalgorithm<<"', secret: "<<Base64Encode(tsigsecret)<<endl;
     TSIGRecordContent trc;
-    if (tsigalgorithm == g_hmacmd5dnsname)
+    if (tsigalgorithm == g_hmacmd5dnsname) {
       trc.d_algoName = g_hmacmd5dnsname_long;
-    else
+    }
+    else {
       trc.d_algoName = tsigalgorithm;
+    }
     trc.d_time = time(nullptr);
     trc.d_fudge = 300;
     trc.d_origID=ntohs(randomid);
diff --git a/pdns/tcpreceiver.cc b/pdns/tcpreceiver.cc
index ab18fff12..600591a01 100644
--- a/pdns/tcpreceiver.cc
+++ b/pdns/tcpreceiver.cc
@@ -683,8 +683,9 @@ int TCPNameserver::doAXFR(const ZoneName &targetZone, std::unique_ptr<DNSPacket>
   if(haveTSIGDetails && !tsigkeyname.empty()) {
     string tsig64;
     DNSName algorithm=trc.d_algoName;
-    if (algorithm == g_hmacmd5dnsname_long)
+    if (algorithm == g_hmacmd5dnsname_long) {
       algorithm = g_hmacmd5dnsname;
+    }
     if (algorithm != g_gsstsigdnsname) {
       if(!db.getTSIGKey(tsigkeyname, algorithm, tsig64)) {
         g_log<<Logger::Warning<<logPrefix<<"TSIG key not found"<<endl;
@@ -1289,8 +1290,9 @@ int TCPNameserver::doIXFR(std::unique_ptr<DNSPacket>& q, int outsock)
     if(haveTSIGDetails && !tsigkeyname.empty()) {
       string tsig64;
       DNSName algorithm=trc.d_algoName; // FIXME400: was toLowerCanonic, compare output
-      if (algorithm == g_hmacmd5dnsname_long)
+      if (algorithm == g_hmacmd5dnsname_long) {
         algorithm = g_hmacmd5dnsname;
+      }
       if (!db.getTSIGKey(tsigkeyname, algorithm, tsig64)) {
         g_log << Logger::Error << "TSIG key '" << tsigkeyname << "' for domain '" << target << "' not found" << endl;
         return 0;
-- 
2.47.2