From c8bf0b969d274036e82381818630eb8651c294f2 Mon Sep 17 00:00:00 2001 From: "Rusydi H. Makarim" Date: Sun, 14 Dec 2025 18:15:12 +0700 Subject: [PATCH] lib/crypto: md5: Use rol32() instead of open-coding it For the bitwise left rotation in MD5STEP, use rol32() from instead of open-coding it. Signed-off-by: Rusydi H. Makarim Link: https://lore.kernel.org/r/20251214-rol32_in_md5-v1-1-20f5f11a92b2@kriptograf.id Signed-off-by: Eric Biggers --- lib/crypto/md5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/crypto/md5.c b/lib/crypto/md5.c index c0610ea1370e6..c4af57db0ea83 100644 --- a/lib/crypto/md5.c +++ b/lib/crypto/md5.c @@ -29,7 +29,7 @@ static const struct md5_block_state md5_iv = { #define F4(x, y, z) (y ^ (x | ~z)) #define MD5STEP(f, w, x, y, z, in, s) \ - (w += f(x, y, z) + in, w = (w << s | w >> (32 - s)) + x) + (w += f(x, y, z) + in, w = rol32(w, s) + x) static void md5_block_generic(struct md5_block_state *state, const u8 data[MD5_BLOCK_SIZE]) -- 2.47.3