From c9a144481d236595bc5bd87ae303e311ad21824f Mon Sep 17 00:00:00 2001 From: Lucas De Marchi Date: Sun, 1 Jan 2012 05:55:25 -0200 Subject: [PATCH] Fix leak of kmod_module and fix code style --- tools/kmod-modprobe.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/kmod-modprobe.c b/tools/kmod-modprobe.c index 2a649dda..c985a837 100644 --- a/tools/kmod-modprobe.c +++ b/tools/kmod-modprobe.c @@ -509,12 +509,14 @@ done: } deps = kmod_module_get_dependencies(mod); - if (deps) { + if (deps != NULL) { kmod_list_foreach(itr, deps) { struct kmod_module *dep = kmod_module_get_module(itr); - if (kmod_module_get_refcnt(dep) == 0) { + + if (kmod_module_get_refcnt(dep) == 0) rmmod_do(dep); - } + + kmod_module_unref(dep); } kmod_module_unref_list(deps); } -- 2.47.2